Test rewrites #9037
Merged
Test rewrites #9037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
reviewed
May 26, 2020
| @@ -197,7 +197,6 @@ object Scanners { | |||
| val noindentSyntax = | |||
| ctx.settings.noindent.value | |||
| || ctx.settings.oldSyntax.value | |||
| || migrateTo3 | |||
There was a problem hiding this comment.
I think having -source 3.0-migrate imply -noindent is intentional: it should allow existing weirdly formatted scala 2 code to compile /cc @odersky.
There was a problem hiding this comment.
The issue is that if a user run compiler with -rewrite, then it's impossible to compile the code again.
It's discovered when we actually compile the rewritten code in the following test:
compileFile("tests/rewrites/rewrites.scala", scala2CompatMode.and("-rewrite", "-indent"))There was a problem hiding this comment.
In that example I think -indent needs to take precedence over migrateTo3 and force indentation to be on.
The code might have been rewritten with `-indent`, but still needs to compile in scala2compat mode.
|
@smarter Could you have a look at the changes again? |
smarter
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test rewrites to avoid accidental regression
Related: #9002 #8982